From: Helge Deller Date: Sun, 16 Nov 2008 23:30:57 +0000 (+0100) Subject: unitialized return value in mm/mlock.c: __mlock_vma_pages_range() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=72eb8c6747b49e41fd2b042510f03ac7c13426fc;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git unitialized return value in mm/mlock.c: __mlock_vma_pages_range() Fix an unitialized return value when compiling on parisc (with CONFIG_UNEVICTABLE_LRU=y): mm/mlock.c: In function `__mlock_vma_pages_range': mm/mlock.c:165: warning: `ret' might be used uninitialized in this function Signed-off-by: Helge Deller [ It isn't ever really used uninitialized, since no caller should ever call this function with an empty range. But the compiler is correct that from a local analysis standpoint that is impossible to see, and fixing the warning is appropriate. ] Signed-off-by: Linus Torvalds --- diff --git a/mm/mlock.c b/mm/mlock.c index a6da2aee940..1ada366570c 100644 --- a/mm/mlock.c +++ b/mm/mlock.c @@ -162,7 +162,7 @@ static long __mlock_vma_pages_range(struct vm_area_struct *vma, unsigned long addr = start; struct page *pages[16]; /* 16 gives a reasonable batch */ int nr_pages = (end - start) / PAGE_SIZE; - int ret; + int ret = 0; int gup_flags = 0; VM_BUG_ON(start & ~PAGE_MASK);