From: Kyle McMartin <kyle@shortfin.cabal.ca>
Date: Sat, 20 Oct 2007 20:23:00 +0000 (-0700)
Subject: [PARISC] fix uninitialized variable warning in asm/rtc.h
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=7210c678202bb3107085bffeb63f66a9b8ba1c85;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

[PARISC] fix uninitialized variable warning in asm/rtc.h

get_rtc_time, in the case that PDC returns that the battery is bad, returns
an unmodified rtc_time arg to the caller, which then uses uninitialized
values. Fix this by memset-ing the arg with zeroes, so it will at least be
cleared if we return failure.

Spotted by John David Anglin.

Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
---

diff --git a/include/asm-parisc/rtc.h b/include/asm-parisc/rtc.h
index f4ebff11dcbd..099d641a42c2 100644
--- a/include/asm-parisc/rtc.h
+++ b/include/asm-parisc/rtc.h
@@ -50,10 +50,10 @@ static inline unsigned int get_rtc_time(struct rtc_time *wtime)
 	long int days, rem, y;
 	const unsigned short int *ip;
 
-	if(pdc_tod_read(&tod_data) < 0)
+	memset(wtime, 0, sizeof(*wtime));
+	if (pdc_tod_read(&tod_data) < 0)
 		return RTC_24H | RTC_BATT_BAD;
 
-
 	// most of the remainder of this function is:
 //	Copyright (C) 1991, 1993, 1997, 1998 Free Software Foundation, Inc.
 //	This was originally a part of the GNU C Library.