From: Matthew Wilcox Date: Fri, 5 Oct 2007 19:55:01 +0000 (-0400) Subject: [SCSI] sym53c8xx: Remove unnecessary check in queuecommand X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=71c222dc45ddf01b0dabb8a4d3e232e13e1452b5;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git [SCSI] sym53c8xx: Remove unnecessary check in queuecommand The midlayer won't scan the host ID, so we don't need to check. This is the only caller of sym_xpt_done2, so remove that too. Signed-off-by: Matthew Wilcox Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c index cfce00ba2b6e..9fc2ae836257 100644 --- a/drivers/scsi/sym53c8xx_2/sym_glue.c +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c @@ -151,13 +151,6 @@ void sym_xpt_done(struct sym_hcb *np, struct scsi_cmnd *cmd) cmd->scsi_done(cmd); } -static void sym_xpt_done2(struct sym_hcb *np, struct scsi_cmnd *cmd, int cam_status) -{ - sym_set_cam_status(cmd, cam_status); - sym_xpt_done(np, cmd); -} - - /* * Tell the SCSI layer about a BUS RESET. */ @@ -323,15 +316,6 @@ static int sym_queue_command(struct sym_hcb *np, struct scsi_cmnd *cmd) struct sym_ccb *cp; int order; - /* - * Minimal checkings, so that we will not - * go outside our tables. - */ - if (sdev->id == np->myaddr) { - sym_xpt_done2(np, cmd, DID_NO_CONNECT); - return 0; - } - /* * Retrieve the target descriptor. */ @@ -537,7 +521,7 @@ static int sym53c8xx_queue_command(struct scsi_cmnd *cmd, struct sym_ucmd *ucp = SYM_UCMD_PTR(cmd); int sts = 0; - cmd->scsi_done = done; + cmd->scsi_done = done; memset(ucp, 0, sizeof(*ucp)); /*