From: Wu Fengguang Date: Tue, 6 Apr 2010 21:34:53 +0000 (-0700) Subject: readahead: fix NULL filp dereference X-Git-Tag: MMI-PSA29.97-13-9~24193 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=70655c06bd3f25111312d63985888112aed15ac5;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git readahead: fix NULL filp dereference btrfs relocate_file_extent_cluster() calls us with NULL filp: [ 4005.426805] BUG: unable to handle kernel NULL pointer dereference at 00000021 [ 4005.426818] IP: [] page_cache_sync_readahead+0x18/0x3e Signed-off-by: Wu Fengguang Cc: Yan Zheng Reported-by: Kirill A. Shutemov Tested-by: Kirill A. Shutemov Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/mm/readahead.c b/mm/readahead.c index 999b54bb462f..dfa9a1a03a11 100644 --- a/mm/readahead.c +++ b/mm/readahead.c @@ -503,7 +503,7 @@ void page_cache_sync_readahead(struct address_space *mapping, return; /* be dumb */ - if (filp->f_mode & FMODE_RANDOM) { + if (filp && (filp->f_mode & FMODE_RANDOM)) { force_page_cache_readahead(mapping, filp, offset, req_size); return; }