From: Flavio Leitner Date: Tue, 19 Apr 2005 00:39:31 +0000 (-0700) Subject: [PATCH] pl2303 - unplug device. X-Git-Tag: MMI-PSA29.97-13-9~57577^2~6 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6fdd8e8e33730a2abc886113bd0b6c4343f63cc9;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git [PATCH] pl2303 - unplug device. It's possible to unplug usb device and do tiocmset() and tiocmget() without valid interface in pl2303 module. The patch below check this and return -ENODEV if interface was removed. From: Flavio Leitner Signed-off-by: Greg Kroah-Hartman diff -purN linux-05-04-11/drivers/usb/serial/pl2303.c linux-05-04-11.usb/drivers/usb/serial/pl2303.c --- diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 3368d2b0412d..a52115407ea1 100644 --- a/drivers/usb/serial/pl2303.c +++ b/drivers/usb/serial/pl2303.c @@ -677,6 +677,9 @@ static int pl2303_tiocmset (struct usb_serial_port *port, struct file *file, unsigned long flags; u8 control; + if (!usb_get_intfdata(port->serial->interface)) + return -ENODEV; + spin_lock_irqsave (&priv->lock, flags); if (set & TIOCM_RTS) priv->line_control |= CONTROL_RTS; @@ -702,6 +705,9 @@ static int pl2303_tiocmget (struct usb_serial_port *port, struct file *file) dbg("%s (%d)", __FUNCTION__, port->number); + if (!usb_get_intfdata(port->serial->interface)) + return -ENODEV; + spin_lock_irqsave (&priv->lock, flags); mcr = priv->line_control; status = priv->line_status;