From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Fri, 3 Jul 2015 11:30:25 +0000 (+0530)
Subject: greybus: connection: Exit connection before destroying it
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6fa1adbcdd28f27b639954e5bb202a2de281679a;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

greybus: connection: Exit connection before destroying it

gb_connection_create() can initialize a connection if bundle->device id
is valid. And so the connection must be destroyed by calling
gb_connection_exit() before gb_connection_destroy(). This wasn't done in
the code that is parsing the manifest.

Fix it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/manifest.c b/drivers/staging/greybus/manifest.c
index ce4e89c6d13e..bea565f1c1d1 100644
--- a/drivers/staging/greybus/manifest.c
+++ b/drivers/staging/greybus/manifest.c
@@ -255,6 +255,7 @@ cleanup:
 	/* An error occurred; undo any changes we've made */
 	list_for_each_entry_safe(connection, connection_next,
 			&bundle->connections, bundle_links) {
+		gb_connection_exit(connection);
 		gb_connection_destroy(connection);
 		count--;
 	}