From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 2 Apr 2016 04:45:01 +0000 (+0300)
Subject: HID: hidraw: silence an uninitialized variable warning
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6edac6fde59e231bd297ebcbc3d1bd395006cd1d;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

HID: hidraw: silence an uninitialized variable warning

My static checker complains that "devid" can be uninitialized if
alloc_chrdev_region() fails.  Fix this by moving the error hanling
forward a couple lines.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index 9c2d7c23f296..4b981fd324e8 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -587,14 +587,13 @@ int __init hidraw_init(void)
 
 	result = alloc_chrdev_region(&dev_id, HIDRAW_FIRST_MINOR,
 			HIDRAW_MAX_DEVICES, "hidraw");
-
-	hidraw_major = MAJOR(dev_id);
-
 	if (result < 0) {
 		pr_warn("can't get major number\n");
 		goto out;
 	}
 
+	hidraw_major = MAJOR(dev_id);
+
 	hidraw_class = class_create(THIS_MODULE, "hidraw");
 	if (IS_ERR(hidraw_class)) {
 		result = PTR_ERR(hidraw_class);