From: Tomas Winkler <tomas.winkler@intel.com>
Date: Wed, 4 Sep 2013 12:35:52 +0000 (+0300)
Subject: hpet: remove useless check if fixmem32 is NULL
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6d3e0d0c1ca926fd6ab557fcd5efb171148f43d6;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

hpet: remove useless check if fixmem32 is NULL

fixmem32 is assigned to address of res->data member
so the address is always valid

Actually since we are not checking for res != NULL
static analyzing is complaining about referencing the pointer
and consequent check for null.
The code snippet looks confusing also for human eyes.

Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 448ce5e29c56..c8f43295d42a 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -971,8 +971,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
 		struct acpi_resource_fixed_memory32 *fixmem32;
 
 		fixmem32 = &res->data.fixed_memory32;
-		if (!fixmem32)
-			return AE_NO_MEMORY;
 
 		hdp->hd_phys_address = fixmem32->address;
 		hdp->hd_address = ioremap(fixmem32->address,