From: joshuaruesweg <ruesweg@woltlab.com>
Date: Mon, 22 Jun 2020 16:04:52 +0000 (+0200)
Subject: Re-add checking whether the video can be played by the browser
X-Git-Tag: 5.3.0_Alpha_1~198^2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6afb2c10c7dda8199fd98e5e380644c5701e8130;p=GitHub%2FWoltLab%2FWCF.git

Re-add checking whether the video can be played by the browser
---

diff --git a/com.woltlab.wcf/templates/__videoAttachmentBBCode.tpl b/com.woltlab.wcf/templates/__videoAttachmentBBCode.tpl
index 95930a7a5b..10b5fbbd37 100644
--- a/com.woltlab.wcf/templates/__videoAttachmentBBCode.tpl
+++ b/com.woltlab.wcf/templates/__videoAttachmentBBCode.tpl
@@ -1,7 +1,20 @@
 <span class="mediaBBCode">
-	<video src="{$attachment->getLink()}" controls></video>
+	<video src="{$attachment->getLink()}" style="display: none;" id="attachmentVideo_{$attachmentIdentifier}" controls></video>
 	
 	<span class="mediaBBCodeCaption">
 		<a href="{$attachment->getLink()}">{$attachment->filename}</a>
 	</span>
 </span>
+
+<script data-relocate="true">
+	{* try to determine if browser might be able to play video *}
+	var video = elById('attachmentVideo_{@$attachmentIdentifier}');
+	var canPlayType = elCreate('video').canPlayType('{$attachment->fileType}');
+	
+	if (canPlayType === '') {
+		elRemove(video);
+	}
+	else {
+		elShow(video);
+	}
+</script>
diff --git a/wcfsetup/install/files/lib/system/bbcode/AttachmentBBCode.class.php b/wcfsetup/install/files/lib/system/bbcode/AttachmentBBCode.class.php
index 2b8e4cc732..c2a28abf6a 100644
--- a/wcfsetup/install/files/lib/system/bbcode/AttachmentBBCode.class.php
+++ b/wcfsetup/install/files/lib/system/bbcode/AttachmentBBCode.class.php
@@ -160,6 +160,7 @@ class AttachmentBBCode extends AbstractBBCode {
 			else if (substr($attachment->fileType, 0, 6) === 'video/' && $parser->getOutputType() == 'text/html') {
 				return WCF::getTPL()->fetch('__videoAttachmentBBCode', 'wcf', [
 					'attachment' => $attachment,
+					'attachmentIdentifier' => StringUtil::getRandomID(),
 				]);
 			}
 			else {