From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Tue, 4 Jul 2017 15:47:23 +0000 (+0200)
Subject: vmlfb: Fix error handling in cr_pll_init()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6af574e826740bf17663b48ba3f8fadb81d2113f;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

vmlfb: Fix error handling in cr_pll_init()

There is an error path, where iomemory is left mapped.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Alan Hourihane <alanh@fairlite.demon.co.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---

diff --git a/drivers/video/fbdev/vermilion/cr_pll.c b/drivers/video/fbdev/vermilion/cr_pll.c
index ebc6e6e0dd0f..ba105c876bed 100644
--- a/drivers/video/fbdev/vermilion/cr_pll.c
+++ b/drivers/video/fbdev/vermilion/cr_pll.c
@@ -185,6 +185,7 @@ static int __init cr_pll_init(void)
 	if (err) {
 		printk(KERN_ERR
 		       "Carillo Ranch failed to initialize vml_sys.\n");
+		iounmap(mch_regs_base);
 		pci_dev_put(mch_dev);
 		return err;
 	}