From: Jiri Pirko Date: Tue, 2 Dec 2014 17:00:34 +0000 (+0100) Subject: net_sched: cls_flow: remove faulty use of list_for_each_entry_rcu X-Git-Tag: MMI-PSA29.97-13-9~11024^2~79 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6a659cd0616299e3444db701820b5a35ae054e0e;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git net_sched: cls_flow: remove faulty use of list_for_each_entry_rcu rcu variant is not correct here. The code is called by updater (rtnl lock is held), not by reader (no rcu_read_lock is held). Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller --- diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c index 4ac515f2a6ce..a6057394a207 100644 --- a/net/sched/cls_flow.c +++ b/net/sched/cls_flow.c @@ -578,7 +578,7 @@ static unsigned long flow_get(struct tcf_proto *tp, u32 handle) struct flow_head *head = rtnl_dereference(tp->root); struct flow_filter *f; - list_for_each_entry_rcu(f, &head->filters, list) + list_for_each_entry(f, &head->filters, list) if (f->handle == handle) return (unsigned long)f; return 0; @@ -654,7 +654,7 @@ static void flow_walk(struct tcf_proto *tp, struct tcf_walker *arg) struct flow_head *head = rtnl_dereference(tp->root); struct flow_filter *f; - list_for_each_entry_rcu(f, &head->filters, list) { + list_for_each_entry(f, &head->filters, list) { if (arg->count < arg->skip) goto skip; if (arg->fn(tp, (unsigned long)f, arg) < 0) {