From: Wei Yongjun Date: Sat, 20 Aug 2016 15:25:32 +0000 (+0000) Subject: spi: spi-fsl-dspi: Drop extra spi_master_put in device remove function X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6999aeabbb703a81a204cb6f9f8f151759a99ac4;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git spi: spi-fsl-dspi: Drop extra spi_master_put in device remove function The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which and results in device memory being freed. The subsequent call to spi_master_put is unnecessary and results in an access to free memory. Drop it. Fixes: 9298bc727385 ("spi: spi-fsl-dspi: Remove spi-bitbang") Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 95d8b929cd52..35c0dd945668 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -763,7 +763,6 @@ static int dspi_remove(struct platform_device *pdev) /* Disconnect from the SPI framework */ clk_disable_unprepare(dspi->clk); spi_unregister_master(dspi->master); - spi_master_put(dspi->master); return 0; }