From: Dan Carpenter Date: Sat, 29 Oct 2011 07:21:06 +0000 (+0300) Subject: Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=685e010748f64a752a981254101e976d7291d16c;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw() ad5360_get_channel_vref() returns an int and scale_uv should be the same. Making it unsigned here breaks the error handling. Signed-off-by: Dan Carpenter Acked-by: Lars-Peter Clausen Acked-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/iio/dac/ad5360.c b/drivers/staging/iio/dac/ad5360.c index c5bf5827c137..012d7147e496 100644 --- a/drivers/staging/iio/dac/ad5360.c +++ b/drivers/staging/iio/dac/ad5360.c @@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev, long m) { struct ad5360_state *st = iio_priv(indio_dev); - unsigned long scale_uv; unsigned int ofs_index; + int scale_uv; int ret; switch (m) {