From: Miklos Szeredi <mszeredi@redhat.com>
Date: Thu, 27 Jul 2017 19:54:05 +0000 (+0200)
Subject: ovl: check snprintf return
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6787341a0f15cc79b9dd4f1341df2f5f3ad3bff1;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

ovl: check snprintf return

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---

diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index 5bc71642b226..aecaadc8f9e7 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -498,6 +498,9 @@ static int ovl_set_nlink_common(struct dentry *dentry,
 	len = snprintf(buf, sizeof(buf), format,
 		       (int) (inode->i_nlink - realinode->i_nlink));
 
+	if (WARN_ON(len >= sizeof(buf)))
+		return -EIO;
+
 	return ovl_do_setxattr(ovl_dentry_upper(dentry),
 			       OVL_XATTR_NLINK, buf, len, 0);
 }