From: Matthias Schmidt <gravatronics@live.com>
Date: Fri, 3 Aug 2018 15:23:15 +0000 (+0200)
Subject: Improve JavaScript code
X-Git-Tag: 5.2.0_Alpha_1~364^2~106^2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=66eed3a1bfb096273895ba17d3a09437df4232f4;p=GitHub%2FWoltLab%2FWCF.git

Improve JavaScript code

See #2509
---

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/Default.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/Default.js
index de04823196..c2ca135b5c 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/Default.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/Default.js
@@ -41,6 +41,7 @@ define(['./Abstract', 'Core', '../Manager'], function(Abstract, Core, Dependency
 			for (var i = start, length = children.length; i < length; i++) {
 				if (!elIsHidden(children.item(i))) {
 					containerShouldBeVisible = true;
+					break;
 				}
 			}
 			
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/Tab.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/Tab.js
index d725eb4c3f..d864e88415 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/Tab.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/Tab.js
@@ -35,6 +35,7 @@ define(['./Abstract', 'Core', 'Dom/Util', '../Manager', 'Ui/TabMenu'], function(
 			for (var i = 0, length = children.length; i < length; i++) {
 				if (!elIsHidden(children.item(i))) {
 					containerShouldBeVisible = true;
+					break;
 				}
 			}
 			
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/TabMenu.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/TabMenu.js
index 563468cb6a..e8dedde8b6 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/TabMenu.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Container/TabMenu.js
@@ -35,6 +35,7 @@ define(['./Abstract', 'Core', 'Dom/Util', '../Manager', 'Ui/TabMenu'], function(
 			for (var i = 0, length = tabMenuListItems.length; i < length; i++) {
 				if (!elIsHidden(tabMenuListItems[i])) {
 					containerShouldBeVisible = true;
+					break;
 				}
 			}
 			
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.js
index bdb92d1447..879940ce7b 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.js
@@ -98,7 +98,7 @@ define(['Dictionary', 'Dom/ChangeListener', 'EventHandler', 'List', 'Dom/Travers
 				}
 				
 				_validatedFieldProperties.set(validatedField, properties);
-			}.bind(this));
+			});
 		},
 		
 		/**
@@ -130,7 +130,7 @@ define(['Dictionary', 'Dom/ChangeListener', 'EventHandler', 'List', 'Dom/Travers
 					
 					_validatedFieldProperties.delete(validatedField);
 				}
-			}.bind(this));
+			});
 		},
 		
 		/**
@@ -166,7 +166,7 @@ define(['Dictionary', 'Dom/ChangeListener', 'EventHandler', 'List', 'Dom/Travers
 		},
 		
 		/**
-		 * Check all dependencies if they are met.
+		 * Checks if all dependencies are met.
 		 */
 		checkDependencies: function() {
 			var obsoleteNodes = [];
@@ -214,7 +214,7 @@ define(['Dictionary', 'Dom/ChangeListener', 'EventHandler', 'List', 'Dom/Travers
 		},
 		
 		/**
-		 * Checks the containers for their availablility.
+		 * Checks the containers for their availability.
 		 * 
 		 * If this function is called while containers are currently checked, the containers
 		 * will be checked after the current check has been finished completely.