From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sat, 19 Jan 2013 12:56:34 +0000 (+0400)
Subject: iwlegacy: don't return zero on failure paths in il4965_pci_probe()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=662845057f2d063461c88a97b737ec7f66daece0;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

iwlegacy: don't return zero on failure paths in il4965_pci_probe()

If hardware is not ready, il4965_pci_probe() breaks off initialization,
deallocates all resources, but returns zero.
The patch adds -EIO as return value in this case.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 10fc2493f415..f1dc04006564 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -6556,6 +6556,7 @@ il4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	il4965_prepare_card_hw(il);
 	if (!il->hw_ready) {
 		IL_WARN("Failed, HW not ready\n");
+		err = -EIO;
 		goto out_iounmap;
 	}