From: Xiubo Li Date: Sun, 28 Sep 2014 09:29:37 +0000 (+0800) Subject: ASoC: core: fix possible ZERO_SIZE_PTR pointer dereferencing error. X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=6596aa047b624aeec2ea321962cfdecf9953a383;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git ASoC: core: fix possible ZERO_SIZE_PTR pointer dereferencing error. Since we cannot make sure the 'params->num_regs' will always be none zero here, and then if it equals to zero, the kmemdup() will return ZERO_SIZE_PTR, which equals to ((void *)16). So this patch fix this with just doing the zero check before calling kmemdup(). Signed-off-by: Xiubo Li Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index d4bfd4a9076f..ae48f1013e80 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3203,7 +3203,7 @@ int snd_soc_bytes_put(struct snd_kcontrol *kcontrol, unsigned int val, mask; void *data; - if (!component->regmap) + if (!component->regmap || !params->num_regs) return -EINVAL; len = params->num_regs * component->val_bytes;