From: Mark Einon Date: Mon, 29 Sep 2014 07:55:41 +0000 (+0100) Subject: staging: et131x: Simplify for loop in et131x_init_send() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=644bbf95f5e2937f4929866e0d8899a9ed42f691;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git staging: et131x: Simplify for loop in et131x_init_send() The for loop in this function increments two variables and has an unusual starting index of 1 (not 0). Make it look more familiar. Reported-by: Dan Carpenter Signed-off-by: Mark Einon Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 4973e6460e57..384dc163851b 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x/et131x.c @@ -1751,7 +1751,7 @@ static void et131x_disable_txrx(struct net_device *netdev) static void et131x_init_send(struct et131x_adapter *adapter) { - u32 ct; + int i; struct tx_ring *tx_ring = &adapter->tx_ring; struct tcb *tcb = tx_ring->tcb_ring; @@ -1759,8 +1759,10 @@ static void et131x_init_send(struct et131x_adapter *adapter) memset(tcb, 0, sizeof(struct tcb) * NUM_TCB); - for (ct = 0; ct++ < NUM_TCB; tcb++) + for (i = 0; i < NUM_TCB; i++) { tcb->next = tcb + 1; + tcb++; + } tcb--; tx_ring->tcb_qtail = tcb;