From: H. Peter Anvin Date: Fri, 8 Feb 2013 01:14:08 +0000 (-0800) Subject: timeconst.pl: Eliminate Perl warning X-Git-Tag: MMI-PSA29.97-13-9~15040^2 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=63a3f603413ffe82ad775f2d62a5afff87fd94a0;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git timeconst.pl: Eliminate Perl warning defined(@array) is deprecated in Perl and gives off a warning. Restructure the code to remove that warning. [ hpa: it would be interesting to revert to the timeconst.bc script. It appears that the failures reported by akpm during testing of that script was due to a known broken version of make, not a problem with bc. The Makefile rules could probably be restructured to avoid the make bug, or it is probably old enough that it doesn't matter. ] Reported-by: Andi Kleen Signed-off-by: H. Peter Anvin Cc: Andrew Morton Cc: --- diff --git a/kernel/timeconst.pl b/kernel/timeconst.pl index eb51d76e058a..3f42652a6a37 100644 --- a/kernel/timeconst.pl +++ b/kernel/timeconst.pl @@ -369,10 +369,8 @@ if ($hz eq '--can') { die "Usage: $0 HZ\n"; } - @val = @{$canned_values{$hz}}; - if (!defined(@val)) { - @val = compute_values($hz); - } + $cv = $canned_values{$hz}; + @val = defined($cv) ? @$cv : compute_values($hz); output($hz, @val); } exit 0;