From: Aishwarya Pant Date: Thu, 2 Mar 2017 18:58:16 +0000 (+0530) Subject: staging: bcm2835-audio: replace printk(KERN_ERR...) with dev_err(...) X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=637e078eafa21b11001490f0abd0255690be2166;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git staging: bcm2835-audio: replace printk(KERN_ERR...) with dev_err(...) Use dev_err(... in place of printk(KERN_ERR ... Problem found by checkpatch Signed-off-by: Aishwarya Pant Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c index 46814fd39b04..659c3d1eaa96 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c @@ -139,10 +139,8 @@ static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol, } } - if (changed) { - if (bcm2835_audio_set_ctls(chip)) - printk(KERN_ERR "Failed to set ALSA controls..\n"); - } + if (changed && bcm2835_audio_set_ctls(chip)) + dev_err(chip->card->dev, "Failed to set ALSA controls..\n"); unlock: mutex_unlock(&chip->audio_mutex);