From: Al Viro Date: Fri, 8 Aug 2014 16:39:16 +0000 (-0400) Subject: __generic_file_write_iter(): fix handling of sync error after DIO X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=60bb45297f7551833346c5cebc6d483ea17ea5f2;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git __generic_file_write_iter(): fix handling of sync error after DIO If DIO results in short write and sync write fails, we want to bugger off whether the DIO part has written anything or not; the logics on the return will take care of the right return value. Cc: stable@vger.kernel.org [3.16] Reported-by: Anton Altaparmakov Signed-off-by: Al Viro --- diff --git a/mm/filemap.c b/mm/filemap.c index 900edfaf6df5..8163e0439493 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2584,7 +2584,7 @@ ssize_t __generic_file_write_iter(struct kiocb *iocb, struct iov_iter *from) * that this differs from normal direct-io semantics, which * will return -EFOO even if some bytes were written. */ - if (unlikely(status < 0) && !written) { + if (unlikely(status < 0)) { err = status; goto out; }