From: H. Nikolaus Schaller <hns@goldelico.com>
Date: Mon, 18 Apr 2016 21:47:14 +0000 (-0700)
Subject: Input: twl6040-vibra - ignore return value of schedule_work
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=5f7fb6f1e514e0ed47aee97752d6ae10491b4841;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

Input: twl6040-vibra - ignore return value of schedule_work

Returning ret is wrong. And checking for an error as well. User space
may call multiple times until the work is really scheduled.

twl4030-vibra.c also ignores the return value.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
index 3a196ada6892..0c853c2c57f8 100644
--- a/drivers/input/misc/twl6040-vibra.c
+++ b/drivers/input/misc/twl6040-vibra.c
@@ -212,11 +212,7 @@ static int vibra_play(struct input_dev *input, void *data,
 	info->strong_speed = effect->u.rumble.strong_magnitude;
 	info->direction = effect->direction < EFFECT_DIR_180_DEG ? 1 : -1;
 
-	ret = schedule_work(&info->play_work);
-	if (!ret) {
-		dev_info(&input->dev, "work is already on queue\n");
-		return ret;
-	}
+	schedule_work(&info->play_work);
 
 	return 0;
 }