From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 17 Aug 2017 19:18:01 +0000 (+0200)
Subject: orangefs: Use kcalloc() in orangefs_prepare_cdm_array()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=5e273a0e06ee5a50bb9cd40026177feca060c101;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

orangefs: Use kcalloc() in orangefs_prepare_cdm_array()

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
---

diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c
index 93fe8f8e60f1..5f59917fd631 100644
--- a/fs/orangefs/orangefs-debugfs.c
+++ b/fs/orangefs/orangefs-debugfs.c
@@ -571,9 +571,7 @@ static int orangefs_prepare_cdm_array(char *debug_array_string)
 		goto out;
 	}
 
-	cdm_array =
-		kzalloc(cdm_element_count * sizeof(struct client_debug_mask),
-			GFP_KERNEL);
+	cdm_array = kcalloc(cdm_element_count, sizeof(*cdm_array), GFP_KERNEL);
 	if (!cdm_array) {
 		rc = -ENOMEM;
 		goto out;