From: Tim Düsterhus <duesterhus@woltlab.com>
Date: Tue, 15 Jun 2021 14:14:50 +0000 (+0200)
Subject: Migrate RecaptchaHandler to Guzzle
X-Git-Tag: 5.5.0_Alpha_1~638^2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=5e0b820af6e23961d23b575f448633d01fe69ef5;p=GitHub%2FWoltLab%2FWCF.git

Migrate RecaptchaHandler to Guzzle

see #4281
---

diff --git a/wcfsetup/install/files/lib/system/captcha/RecaptchaHandler.class.php b/wcfsetup/install/files/lib/system/captcha/RecaptchaHandler.class.php
index fced19c494..3e3d4e6940 100644
--- a/wcfsetup/install/files/lib/system/captcha/RecaptchaHandler.class.php
+++ b/wcfsetup/install/files/lib/system/captcha/RecaptchaHandler.class.php
@@ -2,9 +2,12 @@
 
 namespace wcf\system\captcha;
 
+use GuzzleHttp\ClientInterface;
+use GuzzleHttp\Psr7\Request;
+use Psr\Http\Client\ClientExceptionInterface;
 use wcf\system\exception\UserInputException;
+use wcf\system\io\HttpFactory;
 use wcf\system\WCF;
-use wcf\util\HTTPRequest;
 use wcf\util\JSON;
 use wcf\util\UserUtil;
 
@@ -116,35 +119,37 @@ class RecaptchaHandler implements ICaptchaHandler
             throw new UserInputException('recaptchaString', 'false');
         }
 
-        $request = new HTTPRequest(
+        $request = new Request(
+            'GET',
             \sprintf(
-                'https://www.google.com/recaptcha/api/siteverify?secret=%s&response=%s&remoteip=%s',
-                \rawurlencode($key),
-                \rawurlencode($this->response),
-                \rawurlencode(UserUtil::getIpAddress())
-            ),
-            ['timeout' => 10]
+                'https://www.google.com/recaptcha/api/siteveify?%s',
+                \http_build_query([
+                    'secret' => $key,
+                    'response' => $this->response,
+                    'remoteip' => UserUtil::getIpAddress(),
+                ], '', '&')
+            )
         );
 
         try {
-            $request->execute();
-            $reply = $request->getReply();
-            $data = JSON::decode($reply['body']);
+            $response = $this->getHttpClient()->send($request);
+            $data = JSON::decode((string)$response->getBody());
 
             if ($data['success']) {
                 // yeah
             } else {
                 throw new UserInputException('recaptchaString', 'false');
             }
-        } catch (\Exception $e) {
-            if ($e instanceof UserInputException) {
-                throw $e;
-            }
-
+        } catch (ClientExceptionInterface $e) {
             // log error, but accept captcha
             \wcf\functions\exception\logThrowable($e);
         }
 
         WCF::getSession()->register('recaptchaDone', true);
     }
+
+    private function getHttpClient(): ClientInterface
+    {
+        return HttpFactory::makeClientWithTimeout(5);
+    }
 }