From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Date: Thu, 6 Aug 2009 21:56:43 +0000 (+0000)
Subject: f_phonet: lock-less MTU change
X-Git-Tag: MMI-PSA29.97-13-9~26976^2~446
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=5da63cc4b2258e1c06ee41637492717481025143;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

f_phonet: lock-less MTU change

With the current driver, the MTU is purely indicative, so there is no
need to synchronize with the receive path.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c
index d17f1082df96..f4eff7ca0d36 100644
--- a/drivers/usb/gadget/f_phonet.c
+++ b/drivers/usb/gadget/f_phonet.c
@@ -261,20 +261,10 @@ out:
 
 static int pn_net_mtu(struct net_device *dev, int new_mtu)
 {
-	struct phonet_port *port = netdev_priv(dev);
-	unsigned long flags;
-	int err = -EBUSY;
-
 	if ((new_mtu < PHONET_MIN_MTU) || (new_mtu > PHONET_MAX_MTU))
 		return -EINVAL;
-
-	spin_lock_irqsave(&port->lock, flags);
-	if (!netif_carrier_ok(dev)) {
-		dev->mtu = new_mtu;
-		err = 0;
-	}
-	spin_unlock_irqrestore(&port->lock, flags);
-	return err;
+	dev->mtu = new_mtu;
+	return 0;
 }
 
 static const struct net_device_ops pn_netdev_ops = {