From: Markus Elfring Date: Tue, 2 Dec 2014 17:52:21 +0000 (+0100) Subject: ALSA: trident: Deletion of a check before snd_util_memhdr_free() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=5c34fdf48b9522ca87372b1fae19de8f93ffd130;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git ALSA: trident: Deletion of a check before snd_util_memhdr_free() The snd_util_memhdr_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c index da875dced2ef..57cd757acfe7 100644 --- a/sound/pci/trident/trident_main.c +++ b/sound/pci/trident/trident_main.c @@ -3702,8 +3702,7 @@ static int snd_trident_free(struct snd_trident *trident) free_irq(trident->irq, trident); if (trident->tlb.buffer.area) { outl(0, TRID_REG(trident, NX_TLBC)); - if (trident->tlb.memhdr) - snd_util_memhdr_free(trident->tlb.memhdr); + snd_util_memhdr_free(trident->tlb.memhdr); if (trident->tlb.silent_page.area) snd_dma_free_pages(&trident->tlb.silent_page); vfree(trident->tlb.shadow_entries);