From: Mel Gorman <mgorman@suse.de>
Date: Thu, 29 Nov 2012 21:54:20 +0000 (-0800)
Subject: mm: compaction: fix return value of capture_free_page()
X-Git-Tag: MMI-PSA29.97-13-9~15495^2~6
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=58d002097b98664e2a39cc708f30d11549d870b2;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

mm: compaction: fix return value of capture_free_page()

Commit ef6c5be658f6 ("fix incorrect NR_FREE_PAGES accounting (appears
like memory leak)") fixes a NR_FREE_PAGE accounting leak but missed the
return value which was also missed by this reviewer until today.

That return value is used by compaction when adding pages to a list of
isolated free pages and without this follow-up fix, there is a risk of
free list corruption.

Signed-off-by: Mel Gorman <mgorman@suse.de>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 92871579cbee..7e208f0ad68c 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1422,7 +1422,7 @@ int capture_free_page(struct page *page, int alloc_order, int migratetype)
 		}
 	}
 
-	return 1UL << order;
+	return 1UL << alloc_order;
 }
 
 /*