From: Dan Carpenter <error27@gmail.com>
Date: Wed, 25 Aug 2010 07:12:29 +0000 (+0200)
Subject: sysfs: checking for NULL instead of ERR_PTR
X-Git-Tag: MMI-PSA29.97-13-9~22401^2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=57f9bdac2510cd7fda58e4a111d250861eb1ebeb;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

sysfs: checking for NULL instead of ERR_PTR

d_path() returns an ERR_PTR and it doesn't return NULL.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: stable <stable@kernel.org>
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 1b27b5688f62..da3fefe91a8f 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -340,7 +340,7 @@ static int sysfs_open_file(struct inode *inode, struct file *file)
 	char *p;
 
 	p = d_path(&file->f_path, last_sysfs_file, sizeof(last_sysfs_file));
-	if (p)
+	if (!IS_ERR(p))
 		memmove(last_sysfs_file, p, strlen(p) + 1);
 
 	/* need attr_sd for attr and ops, its parent for kobj */