From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Thu, 16 May 2013 23:36:32 +0000 (+0000)
Subject: dev: remove duplicate 'skb->dev = dev' in dev_forward_skb()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=57b354e66b67c4c72468a26d4313d1217ef32e17;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

dev: remove duplicate 'skb->dev = dev' in dev_forward_skb()

This was added by commit 59b9997baba5 (Revert "net: maintain namespace
isolation between vlan and real device").
In fact, before the initial commit - the one that is reverted -, this
statement was not present.
'skb->dev = dev' is already done in eth_type_trans(), which is call just
after.

Spotted-by: Alain Ritoux <alain.ritoux@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/dev.c b/net/core/dev.c
index fc1e289397f5..18e9730cc4be 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1629,7 +1629,6 @@ int dev_forward_skb(struct net_device *dev, struct sk_buff *skb)
 		return NET_RX_DROP;
 	}
 	skb->skb_iif = 0;
-	skb->dev = dev;
 	skb_dst_drop(skb);
 	skb->tstamp.tv64 = 0;
 	skb->pkt_type = PACKET_HOST;