From: Alexander Ebert Date: Sun, 29 May 2022 15:47:22 +0000 (+0200) Subject: Explicit styling for buttons X-Git-Tag: 6.0.0_Alpha_1~1039^2~2 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=57417897760e2af3d01bd3a11d65af98ec856392;p=GitHub%2FWoltLab%2FWCF.git Explicit styling for buttons --- diff --git a/ts/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.ts b/ts/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.ts index 280aabc2d7..30eae3a534 100644 --- a/ts/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.ts +++ b/ts/WoltLabSuite/Core/Acp/Ui/DataImport/Manager.ts @@ -63,7 +63,7 @@ export class AcpUiDataImportManager implements AjaxCallbackObject { const formSubmit = document.createElement("div"); formSubmit.className = "formSubmit"; - formSubmit.innerHTML = ``; + formSubmit.innerHTML = ``; content.appendChild(formSubmit); UiDialog.rebuild(this); diff --git a/ts/WoltLabSuite/Core/Acp/Ui/Template/Group/Copy.ts b/ts/WoltLabSuite/Core/Acp/Ui/Template/Group/Copy.ts index 185928a141..6ded939c43 100644 --- a/ts/WoltLabSuite/Core/Acp/Ui/Template/Group/Copy.ts +++ b/ts/WoltLabSuite/Core/Acp/Ui/Template/Group/Copy.ts @@ -98,7 +98,7 @@ class AcpUiTemplateGroupCopy implements AjaxCallbackObject, DialogCallbackObject
- +
`, }; } diff --git a/ts/WoltLabSuite/Core/Acp/Ui/User/Action/Handler/Ban/Dialog.ts b/ts/WoltLabSuite/Core/Acp/Ui/User/Action/Handler/Ban/Dialog.ts index 80f6bab152..633da835bb 100644 --- a/ts/WoltLabSuite/Core/Acp/Ui/User/Action/Handler/Ban/Dialog.ts +++ b/ts/WoltLabSuite/Core/Acp/Ui/User/Action/Handler/Ban/Dialog.ts @@ -141,7 +141,9 @@ export class BanDialog {
- +
`, }; } diff --git a/ts/WoltLabSuite/Core/Acp/Ui/Worker.ts b/ts/WoltLabSuite/Core/Acp/Ui/Worker.ts index 9f858aa6d1..6b57923207 100644 --- a/ts/WoltLabSuite/Core/Acp/Ui/Worker.ts +++ b/ts/WoltLabSuite/Core/Acp/Ui/Worker.ts @@ -113,7 +113,8 @@ class AcpUiWorker implements AjaxCallbackObject, DialogCallbackObject { const formSubmit = document.createElement("div"); formSubmit.className = "formSubmit"; - formSubmit.innerHTML = '"; + formSubmit.innerHTML = + '"; content.appendChild(formSubmit); UiDialog.rebuild(this); diff --git a/ts/WoltLabSuite/Core/Media/Manager/Editor.ts b/ts/WoltLabSuite/Core/Media/Manager/Editor.ts index 82172a174d..7966eb3d8f 100644 --- a/ts/WoltLabSuite/Core/Media/Manager/Editor.ts +++ b/ts/WoltLabSuite/Core/Media/Manager/Editor.ts @@ -120,7 +120,7 @@ class MediaManagerEditor extends MediaManager {
- +
`; UiDialog.open({ diff --git a/ts/WoltLabSuite/Core/Ui/Confirmation.ts b/ts/WoltLabSuite/Core/Ui/Confirmation.ts index 5de324c8c3..1edc2d3a0a 100644 --- a/ts/WoltLabSuite/Core/Ui/Confirmation.ts +++ b/ts/WoltLabSuite/Core/Ui/Confirmation.ts @@ -43,11 +43,12 @@ class UiConfirmation implements DialogCallbackObject { this.confirmButton = document.createElement("button"); this.confirmButton.dataset.type = "submit"; - this.confirmButton.classList.add("buttonPrimary"); + this.confirmButton.classList.add("button", "buttonPrimary"); this.confirmButton.textContent = Language.get("wcf.global.confirmation.confirm"); formSubmit.appendChild(this.confirmButton); const cancelButton = document.createElement("button"); + cancelButton.classList.add("button"); cancelButton.textContent = Language.get("wcf.global.confirmation.cancel"); cancelButton.addEventListener("click", () => { UiDialog.close(this); diff --git a/ts/WoltLabSuite/Core/Ui/Message/Share/Dialog.ts b/ts/WoltLabSuite/Core/Ui/Message/Share/Dialog.ts index eececbf400..ff5ad29f57 100644 --- a/ts/WoltLabSuite/Core/Ui/Message/Share/Dialog.ts +++ b/ts/WoltLabSuite/Core/Ui/Message/Share/Dialog.ts @@ -150,7 +150,7 @@ function openDialog(event: MouseEvent): void {
-
- +
`, }; } diff --git a/ts/WoltLabSuite/Core/Ui/Page/Header/Menu.ts b/ts/WoltLabSuite/Core/Ui/Page/Header/Menu.ts index bfbeaa1440..4db052f8fd 100644 --- a/ts/WoltLabSuite/Core/Ui/Page/Header/Menu.ts +++ b/ts/WoltLabSuite/Core/Ui/Page/Header/Menu.ts @@ -185,8 +185,6 @@ function setupA11y(): void { const showMenuButton = document.createElement("button"); showMenuButton.className = "visuallyHidden"; - showMenuButton.tabIndex = 0; - showMenuButton.setAttribute("role", "button"); showMenuButton.setAttribute("aria-label", Language.get("wcf.global.button.showMenu")); element.insertBefore(showMenuButton, link.nextSibling); diff --git a/ts/WoltLabSuite/Core/Ui/Page/JumpTo.ts b/ts/WoltLabSuite/Core/Ui/Page/JumpTo.ts index 44f4dda579..f4dfadb18f 100644 --- a/ts/WoltLabSuite/Core/Ui/Page/JumpTo.ts +++ b/ts/WoltLabSuite/Core/Ui/Page/JumpTo.ts @@ -97,7 +97,7 @@ class UiPageJumpTo implements DialogCallbackObject {
- +
`; return { diff --git a/ts/WoltLabSuite/Core/Ui/Reaction/Profile/Loader.ts b/ts/WoltLabSuite/Core/Ui/Reaction/Profile/Loader.ts index 613231fb4d..aef65465ef 100644 --- a/ts/WoltLabSuite/Core/Ui/Reaction/Profile/Loader.ts +++ b/ts/WoltLabSuite/Core/Ui/Reaction/Profile/Loader.ts @@ -59,7 +59,7 @@ class UiReactionProfileLoader { loadButtonList.appendChild(this._noMoreEntries); this._loadButton = document.createElement("button"); - this._loadButton.className = "small"; + this._loadButton.classList.add("button", "small"); this._loadButton.innerHTML = Language.get("wcf.like.reaction.more"); this._loadButton.addEventListener("click", () => this._loadReactions()); this._loadButton.style.display = "none"; diff --git a/ts/WoltLabSuite/Core/Ui/Redactor/Code.ts b/ts/WoltLabSuite/Core/Ui/Redactor/Code.ts index 867a74d8b4..ac0a983e72 100644 --- a/ts/WoltLabSuite/Core/Ui/Redactor/Code.ts +++ b/ts/WoltLabSuite/Core/Ui/Redactor/Code.ts @@ -255,10 +255,10 @@ class UiRedactorCode implements DialogCallbackObject {
- - +
`, }; } diff --git a/ts/WoltLabSuite/Core/Ui/Redactor/Link.ts b/ts/WoltLabSuite/Core/Ui/Redactor/Link.ts index 8e85620459..7fdd5e32d5 100644 --- a/ts/WoltLabSuite/Core/Ui/Redactor/Link.ts +++ b/ts/WoltLabSuite/Core/Ui/Redactor/Link.ts @@ -95,7 +95,7 @@ class UiRedactorLink implements DialogCallbackObject {
- +
`, }; } diff --git a/ts/WoltLabSuite/Core/Ui/Redactor/Quote.ts b/ts/WoltLabSuite/Core/Ui/Redactor/Quote.ts index 747b1aaab6..11684084ff 100644 --- a/ts/WoltLabSuite/Core/Ui/Redactor/Quote.ts +++ b/ts/WoltLabSuite/Core/Ui/Redactor/Quote.ts @@ -293,10 +293,10 @@ class UiRedactorQuote {
- - +
`, }; } diff --git a/ts/WoltLabSuite/Core/Ui/Redactor/Spoiler.ts b/ts/WoltLabSuite/Core/Ui/Redactor/Spoiler.ts index f452a862be..c939072ebc 100644 --- a/ts/WoltLabSuite/Core/Ui/Redactor/Spoiler.ts +++ b/ts/WoltLabSuite/Core/Ui/Redactor/Spoiler.ts @@ -188,10 +188,10 @@ class UiRedactorSpoiler implements DialogCallbackObject {
- - +
`, }; } diff --git a/ts/WoltLabSuite/Core/Ui/Redactor/Table.ts b/ts/WoltLabSuite/Core/Ui/Redactor/Table.ts index 1a3db5df9d..d650757222 100644 --- a/ts/WoltLabSuite/Core/Ui/Redactor/Table.ts +++ b/ts/WoltLabSuite/Core/Ui/Redactor/Table.ts @@ -71,7 +71,7 @@ class UiRedactorTable implements DialogCallbackObject {
-
`, diff --git a/ts/WoltLabSuite/Core/Ui/User/Activity/Recent.ts b/ts/WoltLabSuite/Core/Ui/User/Activity/Recent.ts index 2520e97157..df785cb256 100644 --- a/ts/WoltLabSuite/Core/Ui/User/Activity/Recent.ts +++ b/ts/WoltLabSuite/Core/Ui/User/Activity/Recent.ts @@ -29,7 +29,8 @@ class UiUserActivityRecent implements AjaxCallbackObject { const showMoreItem = document.createElement("li"); showMoreItem.className = "showMore"; if (this.list.childElementCount) { - showMoreItem.innerHTML = '"; + showMoreItem.innerHTML = + '"; const button = showMoreItem.children[0] as HTMLButtonElement; button.addEventListener("click", (ev) => this.showMore(ev)); diff --git a/ts/WoltLabSuite/Core/Ui/User/Editor.ts b/ts/WoltLabSuite/Core/Ui/User/Editor.ts index 11ad2db8d6..7ea58626ad 100644 --- a/ts/WoltLabSuite/Core/Ui/User/Editor.ts +++ b/ts/WoltLabSuite/Core/Ui/User/Editor.ts @@ -250,7 +250,7 @@ class UserEditor implements AjaxCallbackObject, DialogCallbackObject {
- +
`, }; } diff --git a/wcfsetup/install/files/acp/js/WCF.ACP.js b/wcfsetup/install/files/acp/js/WCF.ACP.js index 71ca36a387..a72c8acc71 100644 --- a/wcfsetup/install/files/acp/js/WCF.ACP.js +++ b/wcfsetup/install/files/acp/js/WCF.ACP.js @@ -278,7 +278,7 @@ WCF.ACP.Package.Installation = Class.extend({ if (this._dialog !== null) { this._purgeTemplateContent($.proxy(function() { var $form = $('
').appendTo($('#packageInstallationInnerContent')); - $('').appendTo($form).click($.proxy(this._rollback, this)); + $('').appendTo($form).click($.proxy(this._rollback, this)); $('#packageInstallationInnerContentContainer').show(); @@ -390,7 +390,7 @@ WCF.ACP.Package.Installation = Class.extend({ this._purgeTemplateContent($.proxy(function() { var $form = $('
').appendTo($('#packageInstallationInnerContent')); - var $button = $('').appendTo($form).click(function() { + var $button = $('').appendTo($form).click(function() { $(this).disable(); window.location = data.redirectLocation; }); @@ -424,7 +424,7 @@ WCF.ACP.Package.Installation = Class.extend({ this._setIcon('question'); var $form = $('
').appendTo($('#packageInstallationInnerContent')); - $('').appendTo($form).click($.proxy(function(event) { + $('').appendTo($form).click($.proxy(function(event) { $(event.currentTarget).disable(); this._submit(data); @@ -1325,7 +1325,7 @@ WCF.ACP.User.BanHandler = { // create dialog this._dialog = $('
').hide().appendTo(document.body); this._dialog.append($('