From: Troy Kisky <troy.kisky@boundarydevices.com>
Date: Fri, 3 Nov 2017 01:58:12 +0000 (-0700)
Subject: rtc: m41t80: m41t80_sqw_set_rate should return 0 on success
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=56073ba4e7068a737a225631b5b642a2cd105b7a;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

rtc: m41t80: m41t80_sqw_set_rate should return 0 on success

commit de6042d2fa8afe22b76e3c68fd6e9584c9415a3b upstream.

Previously it was returning -EINVAL upon success.

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Christoph Fritz <chf.fritz@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index f4c070ea8384..8f5843169dc2 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -510,10 +510,7 @@ static int m41t80_sqw_set_rate(struct clk_hw *hw, unsigned long rate,
 	reg = (reg & 0x0f) | (val << 4);
 
 	ret = i2c_smbus_write_byte_data(client, reg_sqw, reg);
-	if (ret < 0)
-		return ret;
-
-	return -EINVAL;
+	return ret;
 }
 
 static int m41t80_sqw_control(struct clk_hw *hw, bool enable)