From: Dave Jiang Date: Tue, 21 Apr 2009 19:24:56 +0000 (-0700) Subject: edac: ppc mpc85xx fix mc err detect X-Git-Tag: MMI-PSA29.97-13-9~28366 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=55e5750b3e979bac853c0809ad0ef75b7cebd18c;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git edac: ppc mpc85xx fix mc err detect Error found by Jeff Haran. The error detect register is 0s when no errors are detected. The check code is incorrect, so reverse check sense. Reported-by: Jeff Haran Signed-off-by: Dave Jiang Signed-off-by: Doug Thompson Cc: Benjamin Herrenschmidt Acked-by: Kumar Gala Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index 4637a4a757df..7c8c2d72916f 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c @@ -674,7 +674,7 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci) int row_index; err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT); - if (err_detect) + if (!err_detect) return; mpc85xx_mc_printk(mci, KERN_ERR, "Err Detect Register: %#8.8x\n",