From: Ben Greear Date: Wed, 21 Oct 2015 21:53:21 +0000 (-0700) Subject: ath6kl: fix firmware version assignment X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=53cc3291bcfbefc0b3f1e3b7b30ed028b5f1a75d;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git ath6kl: fix firmware version assignment Improper use of strlcpy caused garbage to be appended to the firmware version string. Fix this by paying attention to the ie_lenth. Signed-off-by: Ben Greear Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index 6e473fa4b13c..e3f3a6ae0c0a 100644 --- a/drivers/net/wireless/ath/ath6kl/init.c +++ b/drivers/net/wireless/ath/ath6kl/init.c @@ -994,7 +994,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name) switch (ie_id) { case ATH6KL_FW_IE_FW_VERSION: strlcpy(ar->wiphy->fw_version, data, - sizeof(ar->wiphy->fw_version)); + min(sizeof(ar->wiphy->fw_version), ie_len+1)); ath6kl_dbg(ATH6KL_DBG_BOOT, "found fw version %s\n",