From: Heiner Kallweit Date: Fri, 24 Nov 2017 06:47:50 +0000 (+0100) Subject: eeprom: at24: check at24_read/write arguments X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=52d9bb958f080f0a548139676dbf6a87a40af2a0;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git eeprom: at24: check at24_read/write arguments commit d9bcd462daf34aebb8de9ad7f76de0198bb5a0f0 upstream. So far we completely rely on the caller to provide valid arguments. To be on the safe side perform an own sanity check. Signed-off-by: Heiner Kallweit Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index e0d018e8bb8e..372b2060fbba 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -507,6 +507,9 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count) if (unlikely(!count)) return count; + if (off + count > at24->chip.byte_len) + return -EINVAL; + /* * Read data from chip, protecting against concurrent updates * from this host, but not from other I2C masters. @@ -539,6 +542,9 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count) if (unlikely(!count)) return -EINVAL; + if (off + count > at24->chip.byte_len) + return -EINVAL; + /* * Write data to chip, protecting against concurrent updates * from this host, but not from other I2C masters.