From: NeilBrown Date: Thu, 8 Dec 2011 05:22:48 +0000 (+1100) Subject: md: bad blocks shouldn't cause a Blocked status on a Faulty device. X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=52c64152a935e63d9ff73ce823730c9a23dedbff;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git md: bad blocks shouldn't cause a Blocked status on a Faulty device. Once a device is marked Faulty the badblocks - whether acknowledged or not - become irrelevant. So they shouldn't cause the device to be marked as Blocked. Without this patch, a process might write "-blocked" to clear the Blocked status, but while that will correctly fail the device, it won't remove the apparent 'blocked' status. Signed-off-by: NeilBrown --- diff --git a/drivers/md/md.c b/drivers/md/md.c index f97c3b2f2f89..d730e8f513a7 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2546,7 +2546,8 @@ state_show(struct md_rdev *rdev, char *page) sep = ","; } if (test_bit(Blocked, &rdev->flags) || - rdev->badblocks.unacked_exist) { + (rdev->badblocks.unacked_exist + && !test_bit(Faulty, &rdev->flags))) { len += sprintf(page+len, "%sblocked", sep); sep = ","; }