From: Tim Düsterhus <duesterhus@woltlab.com>
Date: Tue, 15 Nov 2022 14:50:37 +0000 (+0100)
Subject: Remove useless check for `applicationDirectory` in PackageInstallationDispatcher... 
X-Git-Tag: 6.0.0_Alpha_1~712^2~7
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=52bcb2b7a907787003a196e6bf5b0c85a3ae5345;p=GitHub%2FWoltLab%2FWCF.git

Remove useless check for `applicationDirectory` in PackageInstallationDispatcher::installPackage()

The key will always exist in the `$nodeData`.
---

diff --git a/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php b/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php
index 6540373a0b..66063b83a6 100644
--- a/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php
+++ b/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php
@@ -530,11 +530,8 @@ class PackageInstallationDispatcher
         }
         unset($nodeData['requirements']);
 
-        $applicationDirectory = '';
-        if (isset($nodeData['applicationDirectory'])) {
-            $applicationDirectory = $nodeData['applicationDirectory'];
-            unset($nodeData['applicationDirectory']);
-        }
+        $applicationDirectory = $nodeData['applicationDirectory'];
+        unset($nodeData['applicationDirectory']);
 
         // update package
         if ($this->queue->packageID) {