From: Thomas Meyer Date: Sat, 13 Aug 2011 09:31:48 +0000 (+0200) Subject: staging: ft1000: dont cast void* from kmalloc() X-Git-Tag: MMI-PSA29.97-13-9~18234^2^2~864^2~154 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=528959aa08265d1e6b90aaf3767d45b9b57f041b;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git staging: ft1000: dont cast void* from kmalloc() Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c index 3f303ea14337..aaf44c359827 100644 --- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c @@ -485,7 +485,7 @@ void card_send_command(struct ft1000_device *ft1000dev, void *ptempbuffer, DEBUG("card_send_command: enter card_send_command... size=%d\n", size); - commandbuf = (unsigned char *)kmalloc(size + 2, GFP_KERNEL); + commandbuf = kmalloc(size + 2, GFP_KERNEL); memcpy((void *)commandbuf + 2, (void *)ptempbuffer, size); ft1000_read_register(ft1000dev, &temp, FT1000_REG_DOORBELL);