From: Mauro Carvalho Chehab Date: Sun, 10 Aug 2014 02:14:22 +0000 (-0300) Subject: [media] xc5000: be sure that the firmware is there before set params X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=5275a3b6b01664317b1a0bdc95ad981dbbb62283;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git [media] xc5000: be sure that the firmware is there before set params Now that xc5000_set_params() is also called during resume, move the code that checks for the firmware to happen there. This way, the firmware will be loaded either for analog or digital TV when .resume callback is called. Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c index c1905784b08e..512fe508bcd2 100644 --- a/drivers/media/tuners/xc5000.c +++ b/drivers/media/tuners/xc5000.c @@ -1040,6 +1040,11 @@ static int xc5000_set_params(struct dvb_frontend *fe) { struct xc5000_priv *priv = fe->tuner_priv; + if (xc_load_fw_and_init_tuner(fe, 0) != 0) { + dprintk(1, "Unable to load firmware and init tuner\n"); + return -EINVAL; + } + switch (priv->mode) { case V4L2_TUNER_RADIO: return xc5000_set_radio_freq(fe); @@ -1061,11 +1066,6 @@ static int xc5000_set_analog_params(struct dvb_frontend *fe, if (priv->i2c_props.adap == NULL) return -EINVAL; - if (xc_load_fw_and_init_tuner(fe, 0) != 0) { - dprintk(1, "Unable to load firmware and init tuner\n"); - return -EINVAL; - } - switch (params->mode) { case V4L2_TUNER_RADIO: ret = xc5000_config_radio(fe, params);