From: Richard Cochran Date: Sun, 19 Jun 2011 03:31:39 +0000 (+0000) Subject: net: correct comment on where to place transmit time stamp hook. X-Git-Tag: MMI-PSA29.97-13-9~18929^2~422 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4ff75b7cf3b06efb72a50e26008d09b259b1231b;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git net: correct comment on where to place transmit time stamp hook. The comment for the skb_tx_timestamp() function suggests calling it just after a buffer is released to the hardware for transmission. However, for drivers that free the buffer in an ISR, this produces a race between the time stamp code and the ISR. This commit changes the comment to advise placing the call just before handing the buffer over to the hardware. Signed-off-by: Richard Cochran Signed-off-by: David S. Miller --- diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index e8b78ce14474..f3af147c211d 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2023,8 +2023,7 @@ static inline void sw_tx_timestamp(struct sk_buff *skb) * skb_tx_timestamp() - Driver hook for transmit timestamping * * Ethernet MAC Drivers should call this function in their hard_xmit() - * function as soon as possible after giving the sk_buff to the MAC - * hardware, but before freeing the sk_buff. + * function immediately before giving the sk_buff to the MAC hardware. * * @skb: A socket buffer. */