From: Ernst Martin Witte Date: Sat, 9 Jan 2016 20:18:47 +0000 (-0200) Subject: [media] rtl2830: cancel_delayed_work_sync before device removal / kfree X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4fd57ed61564bd4706e71cfd8c5a259079ddabf3;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git [media] rtl2830: cancel_delayed_work_sync before device removal / kfree rtl2830_remove was calling kfree(dev) with possibly still active schedule_delayed_work(&dev->stat_work). A similar bug in si2157 caused kernel panics in call_timer_fn e.g. after rmmod cx23885. Signed-off-by: Ernst Martin Witte Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/dvb-frontends/rtl2830.c b/drivers/media/dvb-frontends/rtl2830.c index b792f305cf15..74b771218033 100644 --- a/drivers/media/dvb-frontends/rtl2830.c +++ b/drivers/media/dvb-frontends/rtl2830.c @@ -900,6 +900,9 @@ static int rtl2830_remove(struct i2c_client *client) dev_dbg(&client->dev, "\n"); + /* stop statistics polling */ + cancel_delayed_work_sync(&dev->stat_work); + i2c_del_mux_adapter(dev->adapter); regmap_exit(dev->regmap); kfree(dev);