From: Steve Glendinning Date: Fri, 4 May 2012 00:57:12 +0000 (+0000) Subject: smsc75xx: eliminate unnecessary phy register read X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4f94a929e4adb0d0ed78d448ff68fe870163c575;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git smsc75xx: eliminate unnecessary phy register read Only a write is necessary to clear the interrupt status, and we don't use the value from the preceding read operation. This patch eliminates the unnecessary read. Signed-off-by: Steve Glendinning Signed-off-by: David S. Miller --- diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c index ecab87b8572..72b62b51c46 100644 --- a/drivers/net/usb/smsc75xx.c +++ b/drivers/net/usb/smsc75xx.c @@ -508,9 +508,7 @@ static int smsc75xx_link_reset(struct usbnet *dev) u16 lcladv, rmtadv; int ret; - /* read and write to clear phy interrupt status */ - ret = smsc75xx_mdio_read(dev->net, mii->phy_id, PHY_INT_SRC); - check_warn_return(ret, "Error reading PHY_INT_SRC"); + /* write to clear phy interrupt status */ smsc75xx_mdio_write(dev->net, mii->phy_id, PHY_INT_SRC, PHY_INT_SRC_CLEAR_ALL);