From: Fenglin Wu Date: Wed, 19 Jul 2017 06:39:55 +0000 (+0800) Subject: pinctrl: qcom: spmi-gpio: Correct power_source range check X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4e83ac4cfbde6b300f31f9460b96c67664a792ce;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git pinctrl: qcom: spmi-gpio: Correct power_source range check Power source selection in DIG_VIN_CTL is indexed from 0, in the range check it shouldn't be equal to the total number of power sources. Signed-off-by: Fenglin Wu Acked-by: Bjorn Andersson Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index 73ce2b5cf9a3..c2c0bab04257 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -487,7 +487,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin, pad->is_enabled = false; break; case PIN_CONFIG_POWER_SOURCE: - if (arg > pad->num_sources) + if (arg >= pad->num_sources) return -EINVAL; pad->power_source = arg; break;