From: Markus Elfring Date: Tue, 25 Apr 2017 08:17:06 +0000 (+0200) Subject: HSI: nokia-modem: Delete error messages for a failed memory allocation in two functions X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4e3b9baa2f798a6cc9865d451269251378067f3a;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git HSI: nokia-modem: Delete error messages for a failed memory allocation in two functions The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such statements here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring Signed-off-by: Sebastian Reichel --- diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c index f6c97a0e1fcd..a774ca7839e1 100644 --- a/drivers/hsi/clients/nokia-modem.c +++ b/drivers/hsi/clients/nokia-modem.c @@ -104,10 +104,8 @@ static int nokia_modem_gpio_probe(struct device *dev) modem->gpios = devm_kcalloc(dev, gpio_count, sizeof(*modem->gpios), GFP_KERNEL); - if (!modem->gpios) { - dev_err(dev, "Could not allocate memory for gpios\n"); + if (!modem->gpios) return -ENOMEM; - } modem->gpio_amount = gpio_count; @@ -156,10 +154,9 @@ static int nokia_modem_probe(struct device *dev) } modem = devm_kzalloc(dev, sizeof(*modem), GFP_KERNEL); - if (!modem) { - dev_err(dev, "Could not allocate memory for nokia_modem_device\n"); + if (!modem) return -ENOMEM; - } + dev_set_drvdata(dev, modem); modem->device = dev;