From: Dan Carpenter Date: Fri, 23 Jun 2017 15:16:25 +0000 (+0300) Subject: NFS: silence a uninitialized variable warning X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4cd1ec95bdec8aedb280ca0f244ededb76f747ab;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git NFS: silence a uninitialized variable warning Static checkers have gotten clever enough to complain that "id_long" is uninitialized on the failure path. It's harmless, but simple to fix. Signed-off-by: Dan Carpenter Signed-off-by: Anna Schumaker --- diff --git a/fs/nfs/nfs4idmap.c b/fs/nfs/nfs4idmap.c index 835c163f61af..dd5d27da8c0c 100644 --- a/fs/nfs/nfs4idmap.c +++ b/fs/nfs/nfs4idmap.c @@ -364,7 +364,8 @@ static int nfs_idmap_lookup_id(const char *name, size_t namelen, const char *typ ret = -EINVAL; } else { ret = kstrtol(id_str, 10, &id_long); - *id = (__u32)id_long; + if (!ret) + *id = (__u32)id_long; } return ret; }