From: Jeff Garzik Date: Fri, 27 Jul 2007 17:01:15 +0000 (-0400) Subject: [SCSI] arcmsr: irq handler fixes, cleanups, micro-opts X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=488a5c8a9a3b67ae117784cd0d73bef53a73d57d;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git [SCSI] arcmsr: irq handler fixes, cleanups, micro-opts * Remove IRQF_DISABLED, it is clearly wrong for this driver. * Remove wasteful spin_lock_irqsave() in interrupt handler. The lighter-weight spin_lock() is all that's needed. * Annotate with FIXME where arcmsr_interrupt() is called without any spinlock being acquired. * Eliminate pointless cast from void pointer in arcmsr_do_interrupt() [jejb: conflict resolution] Signed-off-by: Jeff Garzik Acked-by: Nick Cheng Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 7832a10dc47f..f4d2d523db44 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -422,7 +422,7 @@ static int arcmsr_probe(struct pci_dev *pdev, goto out_release_regions; error = request_irq(pdev->irq, arcmsr_do_interrupt, - IRQF_SHARED, "arcmsr", acb); + IRQF_SHARED, "arcmsr", acb); if (error) goto out_free_ccb_pool;