From: Julia Lawall <julia@diku.dk>
Date: Mon, 16 Aug 2010 16:25:39 +0000 (-0300)
Subject: V4L/DVB: drivers/media/video/zoran: Use available error codes
X-Git-Tag: MMI-PSA29.97-13-9~21911^2~473
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=46a7a3cc9fe11f7a8d58fee6e7d5849298bc0212;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

V4L/DVB: drivers/media/video/zoran: Use available error codes

Error codes are stored in res, but the return value is always 0.  Return
res instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c
index 6f89d0a096ea..c155ddfb1332 100644
--- a/drivers/media/video/zoran/zoran_driver.c
+++ b/drivers/media/video/zoran/zoran_driver.c
@@ -3322,7 +3322,7 @@ zoran_mmap (struct file           *file,
 mmap_unlock_and_return:
 	mutex_unlock(&zr->resource_lock);
 
-	return 0;
+	return res;
 }
 
 static const struct v4l2_ioctl_ops zoran_ioctl_ops = {