From: Linus Walleij Date: Tue, 22 Dec 2015 14:39:05 +0000 (+0100) Subject: m68k: coldfire/gpio: Be sure to clamp return value X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4693c2493a9b2d0c5d407496ea107676a690f1c0;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git m68k: coldfire/gpio: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Geert Uytterhoeven Cc: Greg Ungerer Signed-off-by: Linus Walleij Signed-off-by: Greg Ungerer --- diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c index e7e428681ec5..37a83e27c7a6 100644 --- a/arch/m68k/coldfire/gpio.c +++ b/arch/m68k/coldfire/gpio.c @@ -121,7 +121,7 @@ static int mcfgpio_direction_input(struct gpio_chip *chip, unsigned offset) static int mcfgpio_get_value(struct gpio_chip *chip, unsigned offset) { - return __mcfgpio_get_value(offset); + return !!__mcfgpio_get_value(offset); } static int mcfgpio_direction_output(struct gpio_chip *chip, unsigned offset,