From: Dan Carpenter Date: Wed, 31 Aug 2011 06:38:30 +0000 (+0300) Subject: iwlwifi: signedness bug in iwl_trans_pcie_tx_agg_alloc() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4690c33df6be8bf78a0d5fe58baae33462b0bc1f;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git iwlwifi: signedness bug in iwl_trans_pcie_tx_agg_alloc() unsigned shorts and unsigned chars are never == -1. Signed-off-by: Dan Carpenter Signed-off-by: Wey-Yi Guy Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c index 5dd6a6d1dfd..ea6a0bc8ca2 100644 --- a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c +++ b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c @@ -535,7 +535,7 @@ int iwl_trans_pcie_tx_agg_alloc(struct iwl_trans *trans, struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); struct iwl_tid_data *tid_data; unsigned long flags; - u16 txq_id; + int txq_id; struct iwl_priv *priv = priv(trans); txq_id = iwlagn_txq_ctx_activate_free(trans);