From: Thomas Huehn Date: Tue, 17 Jul 2012 20:16:13 +0000 (+0200) Subject: mac80211_hwsim: fix possible race condition in usage of info->control.sta & control.vif X-Git-Tag: MMI-PSA29.97-13-9~16158^2~30^2~5^2~2 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4581d91b7717152001192112027596fbdeec06f6;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git mac80211_hwsim: fix possible race condition in usage of info->control.sta & control.vif info->control.sta and control.vif may only be dereferenced during the drv_tx call otherwise could lead to use-after-free bugs. Signed-off-by: Thomas Huehn Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 643f968b05ee..00838395778c 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -739,11 +739,6 @@ static void mac80211_hwsim_tx(struct ieee80211_hw *hw, struct sk_buff *skb) txi = IEEE80211_SKB_CB(skb); - if (txi->control.vif) - hwsim_check_magic(txi->control.vif); - if (txi->control.sta) - hwsim_check_sta_magic(txi->control.sta); - ieee80211_tx_info_clear_status(txi); /* frame was transmitted at most favorable rate at first attempt */