From: andrew hendry <andrew.hendry@gmail.com>
Date: Tue, 24 Nov 2009 15:16:05 +0000 (+0000)
Subject: X25: Fix oops and refcnt problems from x25_dev_get
X-Git-Tag: MMI-PSA29.97-13-9~25754^2~163
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=429d33ace5ce6122817f8abe9d170eaa55dc3af9;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

X25: Fix oops and refcnt problems from x25_dev_get

Calls to x25_dev_get check for dev = NULL which was not set.
It allowed x25 to set routes and ioctls on down interfaces.
This caused oopses and refcnt problems on device_unregister.

Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/x25/x25_route.c b/net/x25/x25_route.c
index 66961ea28c91..b95fae9ab393 100644
--- a/net/x25/x25_route.c
+++ b/net/x25/x25_route.c
@@ -136,8 +136,10 @@ struct net_device *x25_dev_get(char *devname)
 #if defined(CONFIG_LLC) || defined(CONFIG_LLC_MODULE)
 					&& dev->type != ARPHRD_ETHER
 #endif
-					)))
+					))){
 		dev_put(dev);
+		dev = NULL;
+	}
 
 	return dev;
 }